fix(@angular-devkit/build-angular): correctly handle data URIs with escaped quotes in stylesheets #23691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: patch
clydin
reviewed
Aug 4, 2022
packages/angular_devkit/build_angular/src/webpack/plugins/postcss-cli-resources.ts
Outdated
Show resolved
Hide resolved
…scaped quotes in stylesheets
Previously, the RegExp didn't correctly handle cases where data URIs had escaped quotes like the below
```css
url("data:image/svg+xml;charset=utf-8,<svg width=/"16/" height=/"15/"></svg>")
```
Closes angular#23680
alan-agius4
force-pushed
the
css-url-quote
branch
from
ad27e6d
to
b20cc0e
Compare
clydin
approved these changes
Aug 4, 2022
alan-agius4
added
action: merge
15 tasks
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Aug 22, 2022
PR angular#23691 introduced a regression that caused paranthesis in url not to be handled correctly. This change correct this behaviour and adds a test case to valid this. Closes angular#23773
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the RegExp didn't correctly handle cases where data URIs had escaped quotes like the below
Closes #23680